Local apps #659
Merged
Local apps #659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julien-c
requested review from
mishig25,
SBrandeis,
osanseviero,
gary149 and
Wauplin
as code owners
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Vaibhavs10
reviewed
May 7, 2024
pcuenca
approved these changes
May 8, 2024
mishig25
reviewed
May 9, 2024
mishig25
reviewed
May 9, 2024
mishig25
reviewed
May 9, 2024
mishig25
reviewed
May 9, 2024
Co-authored-by: Mishig <[email protected]>
Co-authored-by: Mishig <[email protected]>
julien-c
commented
May 10, 2024
There was a problem hiding this comment.
this v1 is ready to merge (cc @krampstudio), shall i merge and we can iterate further in other PRs?
yes it looks a good starting point. btw, I think we should also re-export into https://github.com/huggingface/huggingface.js/blob/main/packages/tasks/src/index.ts (cc @coyotte508) export { LOCAL_APPS } from "./local-apps"
export type { LocalApp, LocalAppKey } from "./local-apps"; |
Vaibhavs10
approved these changes
May 10, 2024
|
good point @krampstudio, want to push this directly to this branch? (and merge it whenever you want) |
Merged
julien-c
added a commit
that referenced
this pull request
May 15, 2024
I hesitated putting this one in `@huggingface/tasks`, or creating a new `@huggingface/hardware`. What do you think? The idea is the community to be able to contribute to that list. ### What I picked for now⤵️ Because I'm lazy – and because it's somewhat linked to #659 – i've added it to `tasks`. --------- Co-authored-by: Pedro Cuenca <[email protected]> Co-authored-by: apolinário <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.